search

opentracing-contrib / java-spring-cloud

Distributed tracing for Spring Boot, Cloud and other Spring projects
Apache License 2.0
390 stars 143 forks source link

Remove support for LoadBalancerFeignClient #324

Closed Stummi closed 3 years ago

Stummi commented 3 years ago

LoadBalancerFeignClient was removed in spring-cloud-openfeign(see here), so this code might raise errors (ClassNotFoundException or NoClassDefFoundError) when used with newer spring versions.

Since it seems the underlying functionality was removed, I guess this code can just be removed as well.

henriquels25 commented 3 years ago

Could we merge this PR?

It would fix all these duplicated issues: https://github.com/opentracing-contrib/java-spring-jaeger/issues/127 https://github.com/opentracing-contrib/java-spring-cloud/issues/312 https://github.com/opentracing-contrib/java-spring-jaeger/issues/114

It is really important so we will be able to use the latest version of Spring Boot and Spring Cloud OpenFeign with this library.

tallpsmith commented 3 years ago

We could really do with this being merged, we're facing the same issue.

AhHa45 commented 3 years ago

please merge this

davidje13 commented 3 years ago

For people who want an equivalent fix for this PR (without waiting for it to be merged), see my comment here: https://github.com/opentracing-contrib/java-spring-cloud/issues/312#issuecomment-914446546

The effect of the code I posted is the same as this PR (but done in a more hacky way so that it can be done from outside). Note that if this PR turns out to have any missing functionality issues, the same will apply to the code I posted.

tallpsmith commented 3 years ago

Thanks @davidje13 - your suggestion worked a treat for me as a workaround, but ideally this is not needed.

I am worried about the lack of further discussion here by the maintainers.

Xyaren commented 3 years ago

Can someone from the maintainers get in on that topic please ? @pavolloffay maybe ?

pavolloffay commented 3 years ago

Folks I don't have time to maintain this project. Does anybody volunteer to move this project forward?

We will need to reconfigure CI to use GH actions and probably fix the release.

DamonYanglong commented 2 years ago

fix opentraceing-spring-cloud-aop pom.xml version ,change version 0.5.10-SNAPSHOT

PaKu5 commented 2 years ago

Can we deploy this change to maven central please?

tejas-sastry commented 1 year ago

Can we deploy this change to maven central please?

@PaKu5 is this available on maven central now?

owaeshin commented 1 year ago

When this fix will be released?

emoussaif commented 1 year ago

Hi @Stummi, @pavolloffay,

Could you please let us know if this will be released ?