search

opentracing-contrib / java-spring-jaeger

Apache License 2.0
256 stars 95 forks source link

Request: Upgade spring-cloud-starter version #123

Open magnuskvalheim opened 3 years ago

magnuskvalheim commented 3 years ago

Hi. There is a fix in recent spring-cloud-starter version for instrumenting kafka and @KafkaListeners. Would you consider upgrade 0.5.3 -> 0.5.9 (or greater) for next release?

For reference: https://github.com/opentracing-contrib/java-spring-cloud/pull/306/commits

geoand commented 3 years ago

Definitely!

Would you like to submit a Pull Request updating the version?

magnuskvalheim commented 3 years ago

Hi @geoand . Sure - I created a PR: https://github.com/opentracing-contrib/java-spring-jaeger/pull/124

Locally, I couldnt get io.opentracing.contrib.java.spring.web.jaeger.starter.it.JaegerIntegrationTest to run. I have a docker on my dev machine though.

"Could not find a valid Docker environment. Please see logs and check configuration"