Open agaudreault opened 4 years ago
It seems like the opentracing.jaeger.remote-controlled-sampler.host-port property is still required to use remote sampling properly.
opentracing.jaeger.remote-controlled-sampler.host-port
In the AutoConfiguration You can see it must be defined to create a RemoteControlledSampler.
https://github.com/opentracing-contrib/java-spring-jaeger/blob/a0a7dadd4bd90fdbc8e455dbda299484e5981985/opentracing-spring-jaeger-starter/src/main/java/io/opentracing/contrib/java/spring/jaeger/starter/JaegerAutoConfiguration.java#L185
The code should check if getHost() || getHostPort() are defined.
getHost() || getHostPort()
Related to https://github.com/opentracing-contrib/java-spring-jaeger/issues/52
agaudreault
commented
4 years ago agaudreault
commented
4 years ago
It seems like the
opentracing.jaeger.remote-controlled-sampler.host-portproperty is still required to use remote sampling properly.In the AutoConfiguration You can see it must be defined to create a RemoteControlledSampler.
https://github.com/opentracing-contrib/java-spring-jaeger/blob/a0a7dadd4bd90fdbc8e455dbda299484e5981985/opentracing-spring-jaeger-starter/src/main/java/io/opentracing/contrib/java/spring/jaeger/starter/JaegerAutoConfiguration.java#L185
The code should check if
getHost() || getHostPort()are defined.