search

opentracing-contrib / java-spring-messaging

OpenTracing Spring Messaging instrumentation
Apache License 2.0
3 stars 11 forks source link

Bump Spring Boot/Cloud versions #16

Closed geoand closed 5 years ago

geoand commented 6 years ago

@gytis @pavolloffay I don't see why the tests would be failing, do you have any ideas?

gytis commented 6 years ago

Just guessing, but there might be a mismatch between Spring Cloud version in here and the one used in the Artemis binder

geoand commented 6 years ago

Interesting... We'll probably have to deal with that sooner or later since we need to support this module actively (and probably use Spring Boot 1.5.12 as well)

gytis commented 6 years ago

I'll test it locally later today

geoand commented 6 years ago

Cool, thanks!

gytis commented 6 years ago

I was right with the suspicion. The issue is with the mismatch of the spring cloud stream version introduced by the spring cloud dependencies version change. Even though in this case this is only a test problem and doesn't influence the functionality of this project, I suggest to upgrade the Artemis binder.

How urgently do you need to merge this pull request?

gytis commented 6 years ago

Just to be clear, I've fixed the issue locally by aligning versions. Now it's the matter of making sure everything is in line and then releasing the new version of the binder, which could then be incorporated to this PR.

geoand commented 6 years ago

Well I don't really know about the urgency of the issue, because there is currently some confusion about the steps needed to productize the various artifacts. I would say we best be prepared as soon as possible :)

gytis commented 6 years ago

OK I'll try to release it today/tomorrow. Also, just to warn you, I think I've made a mistake by tagging first release as 1.0.0.Alpha1. I think I'll step back from it and tag it as 0.0.1.

geoand commented 6 years ago

I am fairly certain we won't need this week, so no immediate rush :)

Thanks for the heads up!

gytis commented 6 years ago

I've released a new version for the Spring Cloud Stream Artemis binder, which would fix this failure. I'll update you're PR once it's synced with Maven Central

pavolloffay commented 5 years ago

Any update on this? Can we use SB 2.x?

geoand commented 5 years ago

I totally forgot about this...

@pavolloffay It seems like this PR is just bumping 1.5.x related deps. We haven't started SB 2.x work on any of our projects yet (although that's coming soon)

pavolloffay commented 5 years ago

the spring cloud has been released for SB 2.x. Which includes a dependency on this project. We should also bump this one.

If this is done could you please merge and cut a new version?

geoand commented 5 years ago

@gytis Do you have any idea?

Otherwise I need to look into it

gytis commented 5 years ago

I'll release the latest Artemis binder version which works with SB 2 and update this PR

geoand commented 5 years ago

Thank you @gytis !

gytis commented 5 years ago

@geoand you were offline and there were a few changes that had to be done, so I'll raised a new PR https://github.com/opentracing-contrib/java-spring-messaging/pull/21. Feel free to cherry-pick the commit to this PR or just close this and review the new one.

geoand commented 5 years ago

Thanks @gytis! I was at a Kubernetes meetup so had to take off early :)

I'll check out the PR soon

geoand commented 5 years ago

@gytis @pavolloffay I think we can close this favor of #21, WDYT?

gytis commented 5 years ago

+1