search

opentracing-contrib / java-spring-messaging

OpenTracing Spring Messaging instrumentation
Apache License 2.0
3 stars 11 forks source link

Remove Events class #3

Closed pavolloffay closed 6 years ago

pavolloffay commented 6 years ago

Events in Events class are zipkin specific. They are not needed

gytis commented 6 years ago

@pavolloffay should I still log something to the active span (e.g. https://github.com/opentracing-contrib/java-spring-messaging/blob/master/opentracing-spring-messaging/src/main/java/io/opentracing/contrib/spring/integration/messaging/OpenTracingChannelInterceptor.java#L74) or is that unnecessary too?

pavolloffay commented 6 years ago

I think it's unnecessary. These events are zipkin specific, for example server send is modeled as span start with an appropriate tag.