search

opentracing-contrib / java-spring-rabbitmq

OpenTracing RabbitMQ instrumentation
Apache License 2.0
18 stars 21 forks source link

Support for tracing other AmqpTemplate send methods #11

Closed sudr closed 5 years ago

sudr commented 5 years ago

The @Around advice currently limits to tracing to just one of the send methods where exchange, routingKey and message are passed as arguments.

This appears quite limiting. Is there a reason for this? Can we expand this pointcut to include other send methods as well?

https://github.com/opentracing-contrib/java-spring-rabbitmq/blob/904bd38465c790a362740ceb8cf4f7f532d35ada/opentracing-spring-rabbitmq/src/main/java/io/opentracing/contrib/spring/rabbitmq/RabbitMqSendTracingAspect.java#L42

wuyupengwoaini commented 5 years ago

The same confusion about these

ask4gilles commented 5 years ago

Fixed by https://github.com/opentracing-contrib/java-spring-rabbitmq/pull/9 org.springframework.amqp.rabbit.core.RabbitTemplate.sendAndReceive and org.springframework.amqp.rabbit.core.RabbitTemplate.convertSendAndReceive will be in 0.1.1

ask4gilles commented 5 years ago

Fixed by https://github.com/opentracing-contrib/java-spring-rabbitmq/pull/9 org.springframework.amqp.rabbit.core.RabbitTemplate.sendAndReceive and org.springframework.amqp.rabbit.core.RabbitTemplate.convertSendAndReceive will be in 0.1.1