search

opentracing-contrib / java-spring-rabbitmq

OpenTracing RabbitMQ instrumentation
Apache License 2.0
18 stars 21 forks source link

Enhancement request: Support for DirectMessageListenerContainer when using RabbitMqReceiveTracingInterceptor #13

Closed sudr closed 5 years ago

sudr commented 5 years ago

Currently the RabbitMqBeanPostProcessor registers the RabbitMqReceiveTracingInterceptor for SimpleMessageListenerContainer. This request is to enhance RabbitMqBeanPostProcessor to support the DirectMessageListenerContainer.

https://github.com/opentracing-contrib/java-spring-rabbitmq/blob/904bd38465c790a362740ceb8cf4f7f532d35ada/opentracing-spring-rabbitmq/src/main/java/io/opentracing/contrib/spring/rabbitmq/RabbitMqBeanPostProcessor.java#L42

ask4gilles commented 5 years ago

@sudr Do you want to submit a PR for this?

sudr commented 5 years ago

Yes. I will submit one today.

sudr commented 5 years ago

I just realized that this will necessitate an upgrade to a minimum of Spring Boot 2.0 dependencies since the DirectMessageListenerContainer is only available beginning in spring-rabbit-2.0 which is available via Spring Boot 2.0 dependencies.

So this change will need to wait for the dependencies to be updated to Spring Boot 2.0 or later. Please let me know how we should proceed.

ask4gilles commented 5 years ago

I just tried to bump SB version, and after fixing some imports, it still breaks a lot of tests :/ So, I've created this separate issue

sudr commented 5 years ago

I'll submit the PR for this once PR #19 is merged.

ask4gilles commented 5 years ago

I'll submit the PR for this once PR #19 is merged. @sudr feel free to add this to 1.0.0 so that I can perform a first release.