opentracing-contrib / java-spring-rabbitmq

OpenTracing RabbitMQ instrumentation
Apache License 2.0
18 stars 21 forks source link

Rename span.kind to produce/consumer #18

Closed wuyupengwoaini closed 5 years ago

wuyupengwoaini commented 5 years ago

https://github.com/opentracing-contrib/java-spring-rabbitmq/blob/e1597e72a4dad3ea49e6e8acbaf22795e5f45075/opentracing-spring-rabbitmq/src/main/java/io/opentracing/contrib/spring/rabbitmq/RabbitMqTracingUtils.java#L36-L53

I view the source and I find the span.kind tag of rabbitmq is rabbitmq-send/ rabbitmq-receive,but the opentracig offers the specification refers https://github.com/opentracing/specification/blob/master/semantic_conventions.md

I think it is better set the [span.kind] tag to producer/consumer