Closed wuyupengwoaini closed 5 years ago
@wuyupengwoaini I've to do some backporting from master. You should really consider upgrading your SB version which will be EOL August this year...
Thanks a lot,Yeah,It's better to upgrade my springboot version but there are many applications which are still use springboot 1.5.x in my company ,so the upgrading process is a long way
@ask4gilles any progress?
Not yet, I’m sorry but I didn’t take the time to do it yet. Hopefully, by the end of the week.
@wuyupengwoaini can you test with 0.1.2-SNAPSHOT and let me know if it fixes your issue so that I can make a new release?
@ask4gilles I'll test it today
@ask4gilles Have you posted the jar package of version 0.1.2-SNAPSHOT to the maven repository? I can not find this dependency .
compile 'io.opentracing.contrib:opentracing-spring-rabbitmq-starter:0.1.2-SNAPSHOT'
@wuyupengwoaini no, you have to use the snapshot repo which is
maven {
url 'http://oss.jfrog.org/artifactory/oss-snapshot-local'
}
@ask4gilles 0.1.2-SNAPSHOT is ok when it's in springboot 1.5.x env
Release 0.1.2 has been published.
I use opentracing-spring-rabbitmq-starter of version 0.1.1,and I use RabbitTemplate to send mq message. The code is following:
this.rabbitTemplate.convertAndSend("hello", "hello");
But I do not receive the producer and consumer span in Jaeger-UI.And then I debug and find that the RabbitMqSendTracingAspect does not take effect.
The root cause is that calls stack is
`@Override public void convertAndSend(String routingKey, final Object object) throws AmqpException { convertAndSend(this.exchange, routingKey, object, (CorrelationData) null); }
The aspect is not cut in the method(convertAndSend(String routingKey, final Object object)) called