opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
107 stars 59 forks source link

Register skipPattern for SB actuator endpoints dynamically. #100

Closed ask4gilles closed 5 years ago

ask4gilles commented 5 years ago

Provide spring boot actuator skip patterns dynamically instead of hard-coded ones. Take care of custom customized management endpoint and context-path. For example, given management.endpoints.web.exposure.include:* you will get the following skip pattern for free: /api-docs.*|/swagger.*|.*\.png|.*\.css|.*\.js|.*\.html|/favicon.ico|/hystrix.stream|/actuator/(auditevents|auditevents/.*|beans|beans/.*|caches|caches/.*|health|health/.*|conditions|conditions/.*|configprops|configprops/.*|env|env/.*|info|info/.*|loggers|loggers/.*|heapdump|heapdump/.*|threaddump|threaddump/.*|metrics|metrics/.*|scheduledtasks|scheduledtasks/.*|httptrace|httptrace/.*|mappings|mappings/.*)

See IT tests for detailed examples.

ask4gilles commented 5 years ago

@geoand can you please review this ?

geoand commented 5 years ago

@ask4gilles Thanks for the PR! I will check this tomorrow.

geoand commented 5 years ago

@ask4gilles Some minor changes, otherwise looks good!

geoand commented 5 years ago

Thanks @ask4gilles!