opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
108 stars 59 forks source link

Finish the span when subscription is canceled #134

Closed NHebrard closed 4 years ago

NHebrard commented 4 years ago

Hello!

With this PR, spans bound to canceled subscriptions will be also finished. Cf this issue: #133

As span finishement is a key behavior, I added a set of tests asserting this action for all the final signals: complete, error, and canceled.

Thanks @geoand.

geoand commented 4 years ago

Thanks for the PR!

Can you please fix the licensing headers of the files you changed? You just need to adjust the "to" year to 2020

NHebrard commented 4 years ago

Should be fine.