search

opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
107 stars 59 forks source link

Include general enable property for RestTemplateTracingAutoConfiguration #137

Closed huehnerlady closed 3 years ago

huehnerlady commented 4 years ago

I would expect, if you set the property opentracing.spring.web.enabled to false, that everything belonging to it will be disabled as well. The RestTemplateTracingAutoConfiguration currently just listens to the property opentracing.spring.web.client.enabled, which is a sub property of the other one. Therefore I suggest to include the basic property in the Conditional and just enable this configuration if both are enabled or missing (opt-out)

geoand commented 4 years ago

Thanks for this!

I am on the fence about it to be honest. Let's see what others think

huehnerlady commented 4 years ago

@geoand any update on what people think? Where can I find a discussion about it (if there is any?)

geoand commented 4 years ago

No comments so far unfortunately

On Mon, Oct 26, 2020 at 2:48 PM Ruth notifications@github.com wrote:

@geoand https://github.com/geoand any update on what people think? Where can I find a discussion about it (if there is any?)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opentracing-contrib/java-spring-web/pull/137#issuecomment-716524002, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBMDP35B7TDPO7N57WNU6DSMVV2LANCNFSM4SQRLR2Q .

huehnerlady commented 4 years ago

If I do not here anything by the end of the year, I would close this pull request, as I am not a fan of loose ends :)

huehnerlady commented 3 years ago

Ok as it seems not to get anywhere I will close this PR now