search

opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
108 stars 59 forks source link

Bump Spring/Spring Boot versions #69

Closed geoand closed 6 years ago

geoand commented 6 years ago

@gytis @pavolloffay Any idea why the tests are failing?

gytis commented 6 years ago

No idea, maybe just try rerunning them.

geoand commented 6 years ago

It seems like I can't restart the tests in Travis because I'm not a member of the repo

pavolloffay commented 6 years ago

build restarted, I have added you both to maintainers

pavolloffay commented 6 years ago

travis keeps failing

gytis commented 6 years ago

I guess some API might have changed. That is the reason why the similar update in java-spring-messaging is failing.

pavolloffay commented 6 years ago

Then it's probably also failing locally (I haven't tried yet).

geoand commented 6 years ago

I think I tried it yesterday and seem to recall that it worked, but I'm not totally sure...

pavolloffay commented 6 years ago

any update on this, it has to pass on travis

geoand commented 6 years ago

I need to take another look, haven't had the time yet :(

geoand commented 6 years ago

I figured out why I couldn't see the failing test locally -> The PR was issued against an old master, against the up-to-date master I can see that the tests is failing locally

geoand commented 6 years ago

@pavolloffay Fixed the PR :)

geoand commented 6 years ago

@pavolloffay Should we go ahead and merge this or are we waiting for more input? Thanks

cmoulliard commented 6 years ago

@pavolloffay @objectiser Can you please review, approve it as we are targeting to propductize it this week using SB-1.5.12 ? Can you release it also ?

objectiser commented 6 years ago

Release of version 0.3.1 initiated.