search

opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
107 stars 59 forks source link

Adding Header SpanDecorators to RestTemplate #84

Closed ledor473 closed 3 years ago

ledor473 commented 6 years ago

Similar to https://github.com/opentracing-contrib/java-web-servlet-filter/pull/49 but for RestTemplate.

There is 2 more PR related to this

cc @jfbreault

ledor473 commented 5 years ago

@pavolloffay regarding this:

As I mentioned in the previous comment I don't like adding new decorators as the same can be achieved by standard filters/interceptors and active span.

Should we get rid of the ResttemplateSpanDecorator class in that case?

ledor473 commented 5 years ago

@pavolloffay I've removed all MDC from this merge request, added the javadoc and fix the naming of various fields. The current conflict is because this branch is meant to be merge after 0.3.4.

I will port it back for 1.x.x right after it's merge in 0.x.x

pavolloffay commented 5 years ago

@ledor473 could you please resolve conflicts?

ledor473 commented 5 years ago

@pavolloffay can you create a branch release-0.x like this one https://github.com/opentracing-contrib/java-spring-cloud/tree/release-0.1

There's no conflict if I compare on this tag, but I cannot send a PR to a tag: https://github.com/opentracing-contrib/java-spring-web/tree/0.3.4