search

opentracing-contrib / java-spring-web

OpenTracing Spring Web instrumentation
Apache License 2.0
107 stars 59 forks source link

Release for SB 2.x #87

Closed geoand closed 5 years ago

geoand commented 6 years ago

We should probably also perform a release supporting SB 2.x (most likely SB 2.1.x).

@pavolloffay How would you like to organize the code for such a release? Would you like to have a separate branch for such a release? Also, what would you like to do about the release versions?

pavolloffay commented 6 years ago

we could do it in master and use branch for 1.x. About the version maybe release SB as 0.2x.x ?

geoand commented 6 years ago

I agree for the branch but I am a little confused about the versioning scheme :P

objectiser commented 6 years ago

I think it might need a major version bump - so start releasing 1.x - as otherwise, if fixes are required on the SB 1.x branch, then it would require a release of 0.x which would become confused with the SB 2.x compatible versions.

Would suggest have a 0.x branch (as it is based on this libraries version), and master then becomes SB2 compatible releasing 1.x versions of this lib.

pavolloffay commented 6 years ago

are there any breaking changes in SB2 web package which would influence us?

geoand commented 6 years ago

@pavolloffay I haven't tested yet, but I don't expect there to be any breaking changes :)

FWIW, I like the suggestion from @objectiser on how to handle the versions

geoand commented 6 years ago

Looks like there are some mockito issues that I need to sort out....