opentracing-contrib / java-vertx-web

OpenTracing instrumentation for Vert.x web package
Apache License 2.0
21 stars 17 forks source link

TracingHandler should ignore active spans #10

Closed fzakaria closed 6 years ago

fzakaria commented 6 years ago

in an event loop model, ThreadLocal in ActiveSpanSource does not work and can lead to tricky problems if not explicitly disabled.

fixes #9

pavolloffay commented 6 years ago

@fzakaria hi sorry I missed this PR. Could you please update the PR, I have merged something which breaks this.

fzakaria commented 6 years ago

@pavolloffay should be clean now.

pavolloffay commented 6 years ago

@fzakaria it seems it is not rebased against master/head as there are references to active span which has been removed.

pavolloffay commented 6 years ago

@fzakaria thanks