opentracing-contrib / java-vertx-web

OpenTracing instrumentation for Vert.x web package
Apache License 2.0
21 stars 17 forks source link

How to use this in vertx-core #13

Closed tosheer closed 6 years ago

tosheer commented 6 years ago

Can you please share some example how we can use this? Like how you can integrate it in the most common example in vertx world https://github.com/cescoffier/my-vertx-first-app/tree/post-2

pavolloffay commented 6 years ago

Hi, this integration is only for vertx-web, post-2 branch uses only vertx-core.

tosheer commented 6 years ago

@pavolloffay yes i was in a bit hurry so pasted the wrong branch link can you please check https://github.com/cescoffier/my-vertx-first-app/blob/post-3 specifically https://github.com/cescoffier/my-vertx-first-app/blob/post-3/src/main/java/io/vertx/blog/first/MyFirstVerticle.java. I tried but i am facing issue in getting the tracer from jaeger configuration as that call seems to be blocking the event loop thread. Can you please point me to some example on how can i do it in vertx? or create a small example?

tosheer commented 6 years ago

@pavolloffay Any update mate?

pavolloffay commented 6 years ago

What specifically is blocking event loop?

Create the tracer singleton at app init time and supply the tracer to the tracing integration. I can have a look at your code if you want.

tosheer commented 6 years ago

@pavolloffay apologies issue was in my code.