search

opentracing-contrib / java-vertx-web

OpenTracing instrumentation for Vert.x web package
Apache License 2.0
21 stars 17 forks source link

Initial impl for tracing web requests #2

Closed pavolloffay closed 7 years ago

pavolloffay commented 7 years ago

Initial impl which traces server requests.

pavolloffay commented 7 years ago

Reroute - is this only rerouting internally? Just wondering if should be separate span, but if just internal then log event is probably good.

Reroute reroutes to the different route. I think we could create a span for each reroute but vertx clears end body handlers on reroute https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImpl.java#L351 so it's not clear how we would properly model start-finish in vertx.

pavolloffay commented 7 years ago

@objectiser thanks, I have asked here https://github.com/vert-x3/vertx-web/issues/523

pavolloffay commented 7 years ago

@cescoffier thanks for the review, most changes applied, comment about adding end handler several times is here https://github.com/opentracing-contrib/java-vertx-web/pull/2#discussion_r126711317. In the code there is also comment that is was not required in the previous version of vertx.

pavolloffay commented 7 years ago

@objectiser @cescoffier @pmlopes thanks for the review!