search

opentracing-contrib / java-vertx-web

OpenTracing instrumentation for Vert.x web package
Apache License 2.0
21 stars 17 forks source link

Web Client support #21

Open luramarchanjozup opened 4 years ago

luramarchanjozup commented 4 years ago

There is Opentracing support for the Web Client (HTTP Client)?

pavolloffay commented 4 years ago

What web client do you exactly mean?

luramarchanjozup commented 4 years ago

What web client do you exactly mean?

Hi @pavolloffay, the Vert.x Web Client: That is an asynchronous HTTP and HTTP/2 client. I mean, because it is not propagated the opentracing headers to the integrations that use HTTP.

yonidavidson commented 3 years ago

So is there anyway to propagate the tracing in vertx 3.x? @pavolloffay @luramarchanjozup

pavolloffay commented 3 years ago

Vertx 3.x is problematic. This library supports only vertx-web.

yonidavidson commented 3 years ago

Hi, I managed to do it by passing context from route context on to vertx context and putting everything on MDC. If you want I can review with you my solution and it works very well. I also created a vertx webclient interceptor that adds all the propagation headers and allows me to fully utilize the Jaeger capabilities.

Yoni Davidson,

On Tue, Dec 1, 2020 at 10:27 AM Pavol Loffay notifications@github.com wrote:

Vertx 3.x is problematic. This library supports only vertx-web.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/opentracing-contrib/java-vertx-web/issues/21#issuecomment-736307756, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJYECXIUQLMG3QNC2OTNQTSSSSG3ANCNFSM4RNWS3XA .