search

opentracing-contrib / java-vertx-web

OpenTracing instrumentation for Vert.x web package
Apache License 2.0
21 stars 17 forks source link

Use travis stages to test different vertx versions #5

Closed pavolloffay closed 7 years ago

pavolloffay commented 7 years ago

@jpkrohling @objectiser could you please review? I am not sure if we need this, but when I was writing this integration I saw some differences in different versions of vertx-web.

pavolloffay commented 7 years ago

@jpkrohling @objectiser Do you prefer this one or #6 ? This is using stages. It has slightly cleaner config but it's more verbose.

objectiser commented 7 years ago

@pavolloffay I think I prefer this one, as it potentially allows other options to be provided with future variations.

jpkrohling commented 7 years ago

This one.

pavolloffay commented 7 years ago

I will merge this. @jpkrohling thanks for matrix :P