search

opentracing-contrib / java-web-servlet-filter

OpenTracing Java Web Servlet Filter Instrumentation
Apache License 2.0
24 stars 31 forks source link

Add error logs/tags in asynclistener on error handler #39

Closed pavolloffay closed 6 years ago

pavolloffay commented 6 years ago

Resolves #36

Signed-off-by: Pavol Loffay ploffay@redhat.com

pavolloffay commented 6 years ago

Unfortunately I wasn't able to test this. Here is the test https://github.com/pavolloffay/java-web-servlet-filter/compare/async-exception-clean...pavolloffay:async-exception-clean-test?expand=1. The error callback is not being invoked.

However I have tested this with spring-web on SB and callback with the exception is invoked. However MVC does not call these callbacks :/