opentracing-contrib / javascript-express

OpenTracing middleware for express
Apache License 2.0
39 stars 20 forks source link

Typescript definitions #15

Open cliedeman opened 5 years ago

cliedeman commented 5 years ago

Would you be open to a PR thats adds typescript type definitions?

meschbach commented 4 years ago

19 was merged today!

batazor commented 3 years ago

@meschbach it looks like this is not included in the latest release on the npm

robertsmieja commented 2 years ago

+1 to creating a new release.

It's quite strange that there are features like type definitions that are 2+ years old and unpublished. Due to that, I've avoided using this package.

meschbach commented 2 years ago

@austinlparker thank you for being an author/mod of OpenTracing!

Is there a scheduled date for release or a mechanism we can kick off to release the library?

austinlparker commented 2 years ago

I'm not entirely sure how releases work from this repository tbh. As an FYI, opentracing is coming close to EOL/read-only mode as OpenTelemetry libraries gain full support. I would suggest looking at the JavaScript documentation for OpenTelemetry found at https://opentelemetry.io/docs/js/ - re: this specific issue/library, I know that it has TypeScript support already as well as instrumentation for express.

That said, I'll do some digging to see if I can figure out how to cut a release of this before we EOL.