Closed malafeev closed 7 years ago
@malafeev, what's your opinion about the existence of both JDBC and JDBI instrumentation? Are they both warranted? Should one replace the other? Should they be part of the same repo? If so, which?
@bhs jdbc is the most low level api. jdbi works above jdbc. Although jdbc instrumentation can replace jdbi instrumentation I suppose that in some cases jdbi instrumentation is convenient to use.
@bhs I propose to create java-jdbc repo with jdbc instrumentation.
and deprecate jdbi
(pointing to jdbc
)
nit: I don't know how jdbc/jdbi instrumentations works, but sometimes it is possible to start spans at lower levels and add some meaningful tags/logs in higher levels. e.g. web filter and spring interceptor. But I don't know if this is the case.
@pavolloffay jdbc/jdbi instrumentation works almost the same way as instrumentation of http clients: start span before request is sent and finish span when response is received. Difference that request/response protocol is not http but jdbc. Higher level can provide active (parent) span with some meaningful tags/logs.
@bhs Please create repository java-jdbc under opentracing-contrib. I would like to transfer OpenTracing JDBC Instrumentation (https://github.com/malafeev/opentracing-java-jdbc).