search

opentracing-contrib / meta

A meta-repository for OpenTracing contributions
Apache License 2.0
35 stars 16 forks source link

New repository for "java-metrics" #28

Closed objectiser closed 7 years ago

objectiser commented 7 years ago

Could you please create a new ot-contrib repo called "java-metrics".

This repository will contain a mechanism for intercepting reported spans to derive metrics that can be reported to metrics systems, with initial support for Prometheus. The intention is to report metrics using a standard set of labels, but also support adding custom labels.

If this approach is successful, then hopefully a similar approach can be used for other OT language clients.

yurishkuro commented 7 years ago

@objectiser which interception mechanism are you planning to use, a wrapper or an observer?

Repo created https://github.com/opentracing-contrib/java-metrics/

objectiser commented 7 years ago

Thanks @yurishkuro.

The initial version will use a wrapper, but that is managed internally, and intention is to move to observer when available.

yurishkuro commented 7 years ago

Sounds good. I would suggest starting with a PR for the README that describes the naming scheme for the metrics, as that is something we've been trying out in Jaeger clients and it's not the most obvious problem to solve, esp. when building support for different transports. One possible approach is here, although I have a couple of concerns with it.