opentracing-contrib / meta

A meta-repository for OpenTracing contributions
Apache License 2.0
35 stars 16 forks source link

OpenTracing spring-cloud instrumentation #29

Closed pavolloffay closed 7 years ago

pavolloffay commented 7 years ago

This is an umbrella issue to discuss an instrumentation for Spring Cloud supported frameworks.

Currently Spring Boot applications are traced using spring-cloud-sleuth, however this framework does not allow to use OpenTracing API. There are two options which could be done:

  1. Reuse sleuth and create OpenTracing integration for it. At the moment sleuth does not provide hooks or API to do this effectively. There is a POC already https://github.com/DealerDotCom/sleuth-opentracing, however it is not an ideal solution for use in production environments.
  2. Natively instrument all spring cloud frameworks. Currently we have instrumentations for spring-web, feign, rxjava and maybe something more. The current approach is to go with micro instrumentations per package/framework. All these micro instrumentations could be combined into one project (opentracing-spring-cloud) which would just contain auto-configurations and integration tests.

Some interesting links:

pavolloffay commented 7 years ago

For now we will go with option 2). Repo is created here https://github.com/opentracing-contrib/java-spring-cloud

pavolloffay commented 7 years ago

Closing, the first version has been released