search

opentracing-contrib / meta

A meta-repository for OpenTracing contributions
Apache License 2.0
35 stars 16 forks source link

openresty/lua #33

Open rbtcollins opened 6 years ago

rbtcollins commented 6 years ago

I'd like to suggest that openresty/lua be on the list of integrations you should actively seek contributors for.

Whats the procedure for donating such an integration, were we to make one?

yurishkuro commented 6 years ago

I was not aware of OpenTracing API being available for Lua, that would be the first step before integrations.

rbtcollins commented 6 years ago

Both are indeed necessary steps :) Whats the procedure for donating such things though?

yurishkuro commented 6 years ago

the biggest challenge is to find some other people interested/experts in the language, so that you can collaborate on the API design to make it idiomatic for the language. OTSC members can review from OT perspective, but I, for example, won't be able to offer much advice on the language features.

Aside from that, we can create a repo and you can start hacking at it.

rbtcollins commented 6 years ago

Just an updated, we've got the c++ based integration with nginx happening for us now, and are still looking into a native Lua implementation for more control; if/when we do that we'll come back here and request a repository once we have at least a POC working.

james-callahan commented 6 years ago

I'm working on an opentracing library for Lua now.

See also https://github.com/opentracing/contrib/issues/8

frankgreco commented 6 years ago

I would be extremely interested in this contribution! @james-callahan do you have a link to your library?

james-callahan commented 6 years ago

@james-callahan do you have a link to your library?

Currently working on it over here: https://github.com/Kong/opentracing-lua

tarekrached commented 5 years ago

is this issue moot in light of opentracing-contrib/nginx-opentracing?

moonming commented 5 years ago

@tarekrached no, the opentracing-OpenResty will be implemented in Lua, and nginx-opentracing is implemented in C++.