search

opentracing-contrib / meta

A meta-repository for OpenTracing contributions
Apache License 2.0
35 stars 16 forks source link

Add opentracing-basic Java library #46

Closed mcumings closed 5 years ago

mcumings commented 5 years ago

Adds a reference to the opentracing-basic bridge library/implementation that I spun up a while back.

Thanks!

yurishkuro commented 5 years ago

@mcumings could you elaborate what you mean by "Basic OpenTracing bridge library"? Is this an equivalent of basictracer-go?

mcumings commented 5 years ago

The README for basictracer-go doesn't give me enough info to answer your question.

The opentracing-basic library implements the opentracing-api specification and provides hooks for supplying behavior to be executed when a span completes, etc. It also leaves the context definition to the consumer, so things like trace ID and span ID details are not baked into the library.

I created this library for consumption on a mobile platform (Android) with a custom back-end for dispatching data originating on the client to an aggregation service. In this sort of environment, the existing libraries all made a lot of assumptions about what libraries could be leveraged, etc..

yurishkuro commented 5 years ago

We generally used the term "basictracer" (https://github.com/opentracing?q=basic) to refer to a "reference" implementation that, for example, can be used to test real instrumentations. It is not performance, does not export spans anywhere (keeps them in memory), but it does provide on the wire context format. Initially it was thought we could use it as the actual base implementation extensible by vendors, but at the time it was too early and there was no real interest from vendors in such impl.

mcumings commented 5 years ago

In that case then it sounds like it matches pretty well. The only delta being that the wire model is undefined in the opentracing-basic library as it is expected to be supplied by the consumer.

yurishkuro commented 5 years ago

Maybe it makes sense to add the default codec that is compatible with Go implementation, then there will be parity in the two projects.

And after that, maybe it makes sense to move the repo to opentracing org

mcumings commented 5 years ago

For now I'd prefer to keep it separate, if that's alright on your end.

mcumings commented 5 years ago

Bump...

austinlparker commented 5 years ago

We're going to be tracking contributions in the OpenTracing Registry now - if you'd still like your contribution listed, please resubmit based on the instructions at https://opentracing.io/get-involved/register/

Thanks!