search

opentracing-contrib / meta

A meta-repository for OpenTracing contributions
Apache License 2.0
35 stars 16 forks source link

spring-cloud-sleuth Adapter #5

Open devinsba opened 7 years ago

devinsba commented 7 years ago

I have created an API adapter layer that allows OpenTracing instrumentation to be used with the spring-cloud-sleuth tracing platform.

My WIP repo is here: https://github.com/DealerDotCom/sleuth-opentracing

Would love to contribute this to OpenTracing once I have tests and a spring-boot starter created

bhs commented 7 years ago

@devinsba sounds great. I would be happy to shepherd this into opentracing-contrib as discussed on Gitter. Let me know how I can help.

First question: we should figure out a repo name. Maybe opentracing-contrib/java-spring-sleuth-adapter? Or just .../java-spring-sleuth?

devinsba commented 7 years ago

java-spring-sleuth-adapter sounds better to me.

My focus in the near term will be getting tests around things and then pushing into the new repo whenever you are able to create it.

Getting ahead of this a bit: Is there a standard release process for the contrib projects? Or should I try to follow the OT/Zipkin release process

bhs commented 7 years ago

@devinsba the TravisCI integration that others have been using is a little annoying to set up (esp the first time) but is a wonderful thing after that initial pain. So that would be my vote.

I am thinking about creating a non-human user for opentracing maven artifacts... that way we wouldn't be using the individual credentials of lots of different people (nor would they all need write access to the maven components, etc). But I don't think I have time to set that up in the very near future.

cmoulliard commented 7 years ago

What is the status about this request ?

devinsba commented 7 years ago

I put things on hold while the Context API was being worked out. I will try to update soon, but will definitely get to it when 1.0 is cut

tedsuo commented 7 years ago

Thanks @devinsba we're definitely interested in an adapter, though my understanding is that what OpenTracing-based tracers can do with it is limited, due to things such as Spans being created in Sleuth, outside of the Tracer's control, plus what you have mentioned in your repo.

So, I'm concerned as to how useful such a bridge can actually be for production tracing. But I would rather have a well made bridge that clearly illuminates what is missing or tricky, even if it is not sufficient for full OT tracing. Also, if you think that production-quality tracing can be done with a Sleuth/OT bridge in it's current state, I'd like to hear the case for it so that I can better understand the current state of things.