Closed lucacome closed 4 months ago
What was the reason for the change @miry ?
@lucacome it was problem with building a new image as I could remember.
As I understand the https://github.com/opentracing-contrib/nginx-opentracing/pull/606/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L204 pointed to bookworm
but we used bullseye
for repo: https://github.com/opentracing-contrib/nginx-opentracing/pull/606/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L206
@lucacome can you share what worklfows were impacted?
UPDATE: Found why I made a change: https://github.com/opentracing-contrib/nginx-opentracing/pull/605 , I expected it would detect the changes with docker image tag as it does for alpine.
@miry dependabot doesn't resolve the ARG
s unfortunately. Also this workflow https://github.com/opentracing-contrib/nginx-opentracing/actions/workflows/update-docker-images.yml has been failing.
I can update it to make it work again, I just wanted to know the reason for the change before starting to work on it.
@lucacome my bad :( . pls fix it
After https://github.com/opentracing-contrib/nginx-opentracing/pull/606