opentracing-contrib / python-django

OpenTracing instrumentation for the Django framework
BSD 3-Clause "New" or "Revised" License
105 stars 54 forks source link

Adding python3 compatibility #22

Closed SGudbrandsson closed 6 years ago

SGudbrandsson commented 6 years ago

A proper fix for python3 compatibility. Thanks to @kbroughton and @mikebryant in https://github.com/opentracing-contrib/python-django/pull/16

Full functionality is maintained

carlosalberto commented 6 years ago

Hey @sigginet sorry for the late review - had my hands full doing other OT things ;)

Thanks for jumping in on top of #16 - I left some comments. Let me know :)

LyleScott commented 6 years ago

Most of the PR feedback here is more in line with what is already at https://github.com/opentracing-contrib/python-django/pull/25

carlosalberto commented 6 years ago

Closing as this is fixed by #25