search

opentracing-contrib / python-django

OpenTracing instrumentation for the Django framework
BSD 3-Clause "New" or "Revised" License
105 stars 54 forks source link

Do not set opentracing.tracer. #29

Closed carlosalberto closed 6 years ago

carlosalberto commented 6 years ago

opentracing.tracer is supposed to be set directly by the user, and consumed from everywhere else, not the other way around (this is how it works under Java and other languages instrumentation code).

mikebryant commented 6 years ago

That isn't how Django works though - people expect to be able to configure Django via the Django SETTINGS, and for everything to flow from that - not to need to call python code explicitly.

(Which is often problematic as the settings module gets called prior to a lot of machinery being ready)

carlosalberto commented 6 years ago

Closing it in favor of #30