search

opentracing-contrib / python-django

OpenTracing instrumentation for the Django framework
BSD 3-Clause "New" or "Revised" License
105 stars 54 forks source link

Set the global tracer based on a parameter. #30

Closed carlosalberto closed 6 years ago

carlosalberto commented 6 years ago

This way, we won't break the contract with other instrumentation libraries, but we still provide this specific case if the user wants to go with it.

carlosalberto commented 6 years ago

@mikebryant Will me merging soon unless you think this is bad ;)

Also, from now, you will be able to get this behavior by doing:

OPENTRACING_SET_GLOBAL_TRACER = True

Let me know ;)

mikebryant commented 6 years ago

Apologies, I'm finding it difficult to get time to focus on this.

This looks good, thanks for keeping the functionality.

carlosalberto commented 6 years ago

Thanks for the feedback @mikebryant. Merged ;)