search

opentracing-contrib / python-django

OpenTracing instrumentation for the Django framework
BSD 3-Clause "New" or "Revised" License
105 stars 54 forks source link

Relax opentracing dependency #37

Closed nothingelsematters7 closed 6 years ago

nothingelsematters7 commented 6 years ago

The most current package version cannot be used with jaeger_client_python due to conflict in opentracing dependency versions Jaeger python client has requirement 

'opentracing>=1.2.2,<2'

(can be seen here https://github.com/jaegertracing/jaeger-client-python/blob/master/setup.py#L42)

while django_opentracing package has the following one

'opentracing>=1.1,<1.2',

I haven't found any specific code using opentracing dependency, which can be broken with a newer version.

carlosalberto commented 6 years ago

Hey, patch looks correct - would you mind fixing the spaces extra spaces, though? We usually try to not mix style changes with functional ones ;)

As soon as this is done, I will issue a release ;)

carlosalberto commented 6 years ago

Thanks a lot! Will issue a release in the next day(s) ;)

carlosalberto commented 6 years ago

Hey @nothingelsematters7 I just released 0.1.19 to include this change ;)