search

opentracing-contrib / python-django

OpenTracing instrumentation for the Django framework
BSD 3-Clause "New" or "Revised" License
105 stars 54 forks source link

Upgrade OT dependency to 2.2.0 #49

Closed jan25 closed 5 years ago

jan25 commented 5 years ago

Jaeger_client latest (4.0.0) requires opentracing <3.0,>=2.1. This conflicts with django_opentracing latest (1.0.1) which requires opentracing<2.1,>=2.0.

Is it safe to upgrade OT dependency to 2.2.0?

Similar issue with flask: https://github.com/opentracing-contrib/python-flask/issues/33

Jamim commented 5 years ago

Hello @jan25,

Is it safe to upgrade OT dependency to 2.2.0?

It looks so.

carlosalberto commented 5 years ago

Closing this Issue, as #53 addressed it. Thanks!

bj00rn commented 5 years ago

@carlosalberto @mikebryant can we expect a release of this?

cheers!

carlosalberto commented 5 years ago

Forgot to mention here that I released last week ;)