opentracing-contrib / python-elasticsearch

OpenTracing instrumentation for the the Python's Elasticsearch clients
Apache License 2.0
11 stars 6 forks source link

Does this library support python 3? #3

Open topher200 opened 6 years ago

topher200 commented 6 years ago

Does this library support python 3? The README nor setup.py reference which versions of python it supports.

carlosalberto commented 6 years ago

@topher200 Hey, no, python 3 is not supported at this time. I plan to add support for this once we release OpenTracing 2.0 ;)

ror6ax commented 6 years ago

@carlosalberto does Py3 has to do with that failing multithreading test?

carlosalberto commented 6 years ago

@ror6ax What multithreading test would be it?

ror6ax commented 6 years ago

One of 3 tests that fail when running py3 -

>       self.assertEqual([False, True], map(lambda x: x.child_of is None, self.tracer.spans))
E       AssertionError: [False, True] != <map object at 0x7fa3ba3cd710>

tests/test_lowlevel.py:232: AssertionError

Another is:

>       return meta['result'] == 'created'
E       KeyError: 'result'

/usr/lib/python3.6/site-packages/elasticsearch_dsl/document.py:427: KeyError

 tests/test_dsl.py ⨯✓  

and

        self.assertEqual(map(lambda x: x.operation_name, self.tracer.spans), [
            'Elasticsearch/test-index',
>           'Elasticsearch/test-index/_mapping/article'
        ])
E       AssertionError: <map object at 0x7fa3ba48cf98> != ['Elasticsearch/test-index', 'Elasticsearch/test-index/_mapping/article']

tests/test_dsl.py:65: AssertionError

 tests/test_dsl.py ⨯     
carlosalberto commented 6 years ago

@ror6ax Those are definitely not related to multithreading - but yes, the first and the third are related to the lack of Python 3 support (not sure about the second one).

erlendvollset commented 4 years ago

Any plans to support py3 and opentracing 2?