search

opentracing / basictracer-go

Basic implementation of the OpenTracing API for Go. 🛑 This library is DEPRECATED!
Apache License 2.0
81 stars 27 forks source link

Build is broken #31

Closed peterbourgon closed 8 years ago

peterbourgon commented 8 years ago

After https://github.com/opentracing/opentracing-go/pull/85, basictracer-go fails with

# github.com/opentracing/basictracer-go
./propagation.go:31: impossible type assertion:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./propagation_ot.go:36: impossible type assertion:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./propagation_ot.go:130: impossible type assertion:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./span.go:65: cannot use s (type *spanImpl) as type opentracing.Span in return argument:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./span.go:78: cannot use s (type *spanImpl) as type opentracing.Span in return argument:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./span.go:81: cannot use s (type *spanImpl) as type opentracing.Span in return argument:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./span.go:88: cannot use s (type *spanImpl) as type opentracing.Span in return argument:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./span.go:163: cannot use s (type *spanImpl) as type opentracing.Span in return argument:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./span.go:170: cannot use s (type *spanImpl) as type opentracing.Span in return argument:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./tracer.go:157: impossible type assertion:
        *spanImpl does not implement opentracing.Span (missing ForeachBaggageItem method)
./tracer.go:157: too many errors

Detected in Go kit; link to Circle.

/cc @yurishkuro

petermattis commented 8 years ago

Ditto https://circleci.com/gh/cockroachdb/examples-go/192.

yurishkuro commented 8 years ago

I'm patching just the API part (#32) since the larger PR #30 needs revisions.

yurishkuro commented 8 years ago

@peterbourgon @petermattis #32 has been merged, please confirm it fixes the issues

petermattis commented 8 years ago

Yep, looks fixed to me.

yurishkuro commented 8 years ago

Sorry for the noise, I didn't realize you guys are pulling the latest instead of pinning to a version.

petermattis commented 8 years ago

@yurishkuro We're pinning to a version in our main repo, but not in this examples-go repo. Now I'm running into an incompatibility with another dependency. Probably time to start pinning dependencies everywhere.

bhs commented 8 years ago

@yurishkuro thanks for dealing with this!

<insert screed about the lack of great options for Go dependency management here>