Adjust to the new key-value logging regime

opentracing / basictracer-go

Basic implementation of the OpenTracing API for Go. 🛑 This library is DEPRECATED!

Apache License 2.0

81 stars 27 forks source link

Adjust to the new key-value logging regime #37

Closed bhs closed 8 years ago

bhs commented 8 years ago

(As proposed in https://github.com/opentracing/opentracing-go/pull/108)

cc: @yurishkuro @tschottdorf

RaduBerinde commented 8 years ago

We also need to adjust NetTraceIntegrator to handle EventLogFields, no?

bhs commented 8 years ago

@RaduBerinde that makes sense (kinda), though I have never used the NetTraceIntegrator myself... if I broke a build somewhere, let me know and I'll look into this and fix. Otherwise, I can either "put it on my list" or you can include the (presumably trivial) change in your outstanding PR as a one-off commit.

RaduBerinde commented 8 years ago

Yes, I can do it, it should be an easy change. I don't think any build is broken, just that messages that use LogKV/LogFields won't show up. The only thing I'm not sure is how to format a LogRecord into a single readable string.