search

opentracing / lua-bridge-tracer

Provides an implementation of the Lua OpenTracing API on top of the C++ API
Apache License 2.0
14 stars 13 forks source link

Opentracing 1.6.0 compatibility #12

Closed hugo19941994 closed 1 year ago

hugo19941994 commented 4 years ago

Hi. It looks like v0.1.1 of lua-bridge-tracer doesn't work with opentracing-cpp 1.6.0.

It's been a while since I've done any C++ coding, but it looks like by just implement the 3 missing methods it compiles and works OK. I've updated and tested the hello-world example and the CI pipeline with lua 5.1, 5.2 and 5.3.

As jaeger-client-cpp still doesn't have a release with Opentracing 1.6.0 compatibility I had to compile the master branch manually in the hello-world example. This slows down the Docker container build a fair bit...

dekimsey commented 4 years ago

Thank you for doing this, I ran into the same problem. The PR addressed my issues as it allowed 1.6.0 to build the library.