search

opentracing / opentracing-csharp

OpenTracing API for C# (.NET). 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
517 stars 73 forks source link

Add a binary propagator format option #116

Closed austinlparker closed 5 years ago

austinlparker commented 5 years ago

This adds a builtin Binary Propagator format for consumers of the API.

carlosalberto commented 5 years ago

So I think this is a good addition overall - although some feedback given to the Binary stuff in Java can be applied here, regarding Stream having members that are not related to the current scenario (CanRead, CanWrite, CopyTo, etc).

I'd personally be up for adding this with a note on it being experimental, so people know it could change in the next versions (which actually happened to the Java side, when we changed it from using ByteBuffer to the `Binary wrapper ;) )

austinlparker commented 5 years ago

I was thinking about that, but I'm also not entirely sure how many of the problems that people ran into on Java are going to be a problem here. I like the experimental idea though.