Closed cwe1ss closed 6 years ago
Hey @cwe1ss - thanks for collating the release milestone. I think what you have proposed all makes sense and I agree including the additional three commits would be beneficial.
Regarding your open questions:
Alright, to move things forward, I went ahead and merged some PRs and put a time limit on the others. I'd like to do a release next week if that's ok for everyone.
I merged the other PRs and created the "0.12.0-rc1" release candidate!
Release notes: https://github.com/opentracing/opentracing-csharp/releases/tag/0.12.0-rc1 NuGet package: https://www.nuget.org/packages/OpenTracing/0.12.0-rc1
Please give it a try! I'd like to do the final release at the end of next week if there's no objections.
PS: Not sure yet if we should include #84 as well?! There's no definitive answer yet in that linked issue.
Thanks for all your work on this @cwe1ss
No objections so far, so I'll go ahead and release it NOW.
v0.12.0 has been released!
Release notes: https://github.com/opentracing/opentracing-csharp/releases/tag/0.12.0 NuGet package: https://www.nuget.org/packages/OpenTracing/0.12.0
Milestone details: https://github.com/opentracing/opentracing-csharp/milestone/5
Relevant merged changes so far:
74 Improved XML docs
80 OpenTracing assembly should be signed
83 Updating MockTracer to use AsyncLocalScopeManager
These have been small non-breaking changes. We could do a servicing release with them but I'd prefer having fewer big releases to make sure people don't have to update their dependencies too often. For that reason, I'd like to also get some other important issues done.
My candidates would be:
72 Added SetTag and WithTag for use with OpenTracing.Tag.Tags
75 StartActive() overload with finishSpanOnDispose:true
91 Use IEnumerable<KeyValuePair<string, object>> for Log() methods (again)
Would be great to get some more feedback/approval on these issues to get them done asap.
Other open questions:
What's your opinions on the frequency of releases? Anything else that should be included?