Auto finish scope manager

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163

http://opentracing.io

Apache License 2.0

1.68k stars 344 forks source link

Auto finish scope manager #241

Closed carlosalberto closed 6 years ago

carlosalberto commented 6 years ago

Creating this PR in order to move the AutoFinishScopeManager from the examples module into the util one, so this can be accessible to other libraries (even if we don't support the Continuation concept out of the box anymore).

I'm playing with this possibility as both the v030 and the akka support will optionally offer this flavor of ScopeManager, and thought it could be helpful for other people/projects overall.

Opinions on this? Shall we put it here and expose it publicly?

pavolloffay commented 6 years ago

LGTM, I would be interested how this will work with brave-opentracing

carlosalberto commented 6 years ago

@pavolloffay sure!

@yurishkuro Objections?

yurishkuro commented 6 years ago

fine with me

carlosalberto commented 6 years ago

Merged, preparing it to be part of the final release.