search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

Make Binary use byte arrays instead of ByteBuffer instances. #245

Closed carlosalberto closed 6 years ago

carlosalberto commented 6 years ago

This is an approach for 'solving' #243, as a compromise between streams and ByteBuffer approaches.

Adapters for Channels have been removed, but we can include them in next releases if still desired.

MockTracer has been updated as well.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 82.456% when pulling 6ad90fbb0b8ca3081f98fbd46a172258dd2b8403 on carlosalberto:binary_byte_array into 91d4ff7bd3e6b9aa8bc362d06455b7bdf58c0c8a on opentracing:v0.31.0.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 82.456% when pulling b06ca66e48d259b73d511f6a5c172e345e1a34d8 on carlosalberto:binary_byte_array into 91d4ff7bd3e6b9aa8bc362d06455b7bdf58c0c8a on opentracing:v0.31.0.

carlosalberto commented 6 years ago

Closing as we have decided to roll back the current binary format until consensus is achieved.