Binary release adjustments

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163

http://opentracing.io

Apache License 2.0

1.68k stars 344 forks source link

Binary release adjustments #246

Closed carlosalberto closed 6 years ago

carlosalberto commented 6 years ago

This is a PR to update MockTracer and the inline documentation for Binary prior to the 0.31 release (after the feedback we got in #243).

MockTracer's Binary propagator must loop over Binary.write() when injecting a context (instead of a single write() ).
Clarify that the Binary methods for reading/writing work like the ones of a (synchronous) Channel, but they don't need to belong to an actual Channel.

coveralls commented 6 years ago

Changes Unknown when pulling 256e85ea3f9b756f3ba786446c728c041ed27c01 on carlosalberto:binary_release_adjustments into on opentracing:v0.31.0.

carlosalberto commented 6 years ago

Closing as we have decided to roll back the current binary format until consensus is achieved.