search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

Deprecate the StringTag.set() overload taking a StringTag. #262

Closed carlosalberto closed 6 years ago

carlosalberto commented 6 years ago

It's not a common scenario to use a Tag key as the tag value. Would fix #229

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.515% when pulling 67538cf5cbb27d44b3a6c3ec9eff6a4a4e2e627c on carlosalberto:deprecate_stringtag_overload into 242ba956368c48b804ae4120053955a49f7f9c63 on opentracing:v0.32.0.

carlosalberto commented 6 years ago

Merged as it's a rather simple (and obvious) change. Let me know if this needs to be undone later ;)

cwe1ss commented 6 years ago

@carlosalberto fyi: this has been merged into the v0.32.0 branch but there have also already been merges into the master branch (#263, #264).

carlosalberto commented 6 years ago

@cwe1ss Hey, yes, was wondering about that yesterday. I will back port this deprecation, as once as I get my mind on whats the best (direct cherry-pick or PR ;) )