Closed pavolloffay closed 5 years ago
cc @opentracing/opentracing-java-maintainers
@sjoerdtalsma I have added a commit fixing your comment and also fixing other javadoc (referencing deprecated method)
I have changed the target branch to v0.32.0
@sjoerdtalsma Is this good to go? If yes, please merge it so this can be included in RC1 ;)
I still don't understand the following javadoc:
Use {@link #registerIfAbsent(Callable)} for use cases when the tracer can be instantiated multiple times.
Where does GlobalTracer say anything about instantiating multiple times? The callable use case is for guaranteed 'at most once' initialization. You may also call it Lazy initialization. I don't want to block for a javadoc comment, but I get more questions than answers when reading this.
LGTM, :ship: it
Awesome! Will be including this change in RC1 ;)
Resolves https://github.com/opentracing/opentracing-java/issues/286
Signed-off-by: Pavol Loffay ploffay@redhat.com