search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

Bump JaCoCo to use a Java 10 friendly version #306

Closed jpkrohling closed 5 years ago

jpkrohling commented 5 years ago

Before this change, building this library with a Java 10 JDK results in a failure, such as:

[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ opentracing-api ---
[INFO] Surefire report directory: /mnt/storage/jpkroehling/Projects/src/github.com/opentracing/opentracing-java/opentracing-api/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Exception in thread "main" java.lang.reflect.InvocationTargetException
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:564)
    at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:510)
    at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:522)
Caused by: java.lang.RuntimeException: Class java/util/UUID could not be instrumented.
    at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:140)
    at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:101)
    at org.jacoco.agent.rt.internal_8ff85ea.PreMain.createRuntime(PreMain.java:55)
    at org.jacoco.agent.rt.internal_8ff85ea.PreMain.premain(PreMain.java:47)
    ... 6 more
Caused by: java.lang.NoSuchFieldException: $jacocoAccess
    at java.base/java.lang.Class.getField(Class.java:1958)
    at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:138)
    ... 9 more
FATAL ERROR in native method: processing of -javaagent failed

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] OpenTracing (Parent) ............................... SUCCESS [  2.343 s]
[INFO] OpenTracing API .................................... FAILURE [  2.496 s]

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.02%) to 75.13% when pulling 3fd39d6342876983b545651f64715b76ac75741b on jpkrohling:Bump-JaCoCo into d988630cb2dcb3544f116327464039bf07848293 on opentracing:master.