Closed tylerbenson closed 5 years ago
+1
Nice one. Why is this considered a breaking change?
If someone implements the Span interface (e.g. as a decorator), then any change to the interface is a breaking change. But we typically allowed additions.
We have 2 approvals. @tedsuo @austinlparker do you want to review?
+1
One thing to note, I didn't follow @cwe1ss's suggestion to split the method declaration out by type. I don't have anything against that. If y'all prefer the non-generic option I can do that instead. Thoughts?
LGTM
@yurishkuro Approved - is it ok if I go ahead and merge?
Reduces the need to call Tags.SOMETAG.getKey() and adds type safety for setTag if done from the span.
Fixes #271