search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

Deprecate ScopeManager.active() #326

Closed carlosalberto closed 5 years ago

carlosalberto commented 5 years ago

Addresses #267

  1. ScopeManager.active() is deprecated.
  2. Tests around it are kept, till we fully remove it.
  3. Its usage is removed from testbed though.
  4. Updated AutoFinishScopeManager (a rather exoteric manager) to also offer its capture/continue workflow without relying on a publicly visible Scope.
  5. Added a test case showing the case when the even handler or request handler has no object to store the Scope object, being solved by using a thread-local field.

Probably the important point is 5) - as it shows a concrete scenario that has historically prevented us from removing active() altogether. I'm hope this case is not over simplifying this requirement ;)

@opentracing/opentracing-java-maintainers please feel free to leave your opinion, as I'd like to have this included in 0.32 if possible ;)

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 77.131% when pulling 650f48a5a6196ddaac44820d05ae5de903c96bbd on carlosalberto:remove_scopemanager_active into a0b972eab72e39de95829ebdf5909e183d7e1c0f on opentracing:v0.32.0.

carlosalberto commented 5 years ago

Just added a commit to add the new example to the testbed README.

Unless somebody is not happy with this change, I will be merging this PR tomorrow in order to (very soon) issue a second 0.32 release candidate.

carlosalberto commented 5 years ago

Merged prior to preparing a second RC for 0.32 ;)