search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

Deprecate AutoFinishScopeManager #335

Closed carlosalberto closed 5 years ago

carlosalberto commented 5 years ago

The last fix before releasing 0.32 ;)

@yurishkuro

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 77.301% when pulling 9ccbc1c0f6d5bb674d046fd26cfd3785557afc69 on carlosalberto:deprecate_autofinishscopemanager into e2f928090c2ae6867011f42d0ec5d52768e388c4 on opentracing:v0.32.0.

yurishkuro commented 5 years ago

The operating mode this classes proposes is in contrast with the main philosophy of 0.32 where we deprecated autoFinish flag in activate (), because it too easily leads to programming mistakes of using try-with-resource on the scope and not having the right span to handle errors.

I think we should stick with one recommended instrumentation pattern, shown in 0.32 readme, instead of having the instrumentation be dependent on which scope manager is in use.

carlosalberto commented 5 years ago

Also, the historical context is that we wanted to preserve this for people migrating from 0.30.

That being said, I will add this and @yurishkuro 's note and then merge.

carlosalberto commented 5 years ago

Hey hey guys - if you are ok with this, I will merge later today, and issue the 0.32 release right after ;)

Let me know.