Remove Deprecated members.

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163

http://opentracing.io

Apache License 2.0

1.68k stars 344 forks source link

Remove Deprecated members. #339

Closed carlosalberto closed 5 years ago

carlosalberto commented 5 years ago

Clean up and remove Deprecated members. The important ones are:

Scope ScopeManager.active()
void ScopeManager.activate(Span, boolean)
Span Scope.activeSpan()
SpanBuilder.startActive(Span, boolean)
SpanBuilder.startManual()
AutoFinishScopeManager (it now exists under testbed for a few test cases, but we won't expose it in the actual API)

coveralls commented 5 years ago

Coverage decreased (-1.1%) to 76.18% when pulling 77fa5ea5de27c07a409cc5c5de9db74661b617b9 on remove_deprecated_members into 6b2998d72fe8118d84df3537d809ef57d7f74b8a on master.

carlosalberto commented 5 years ago

Hello everybody - I'd like to have this one merged soon. Unless there's any objection, I will merge this one by the end of the week.

tylerbenson commented 5 years ago

@adriancole does this cover what you wanted removed?

carlosalberto commented 5 years ago

Merged - if you think there's something that shouldn't have been removed or something is missing, let me know, etc.